-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can u finish the TODO: add checkpoints? #63
Comments
This is probably going to be a must-have for #82 |
If we were to hack through it ourselves, would we be trying to minimize discriminator or perceptual loss as a criteria for saving a checkpoint? As it stands now, when training is complete, the weights that reside in the model is just the result of the last step taken? |
@krasserm I am trying to piece together the SrganTrainer checkpoint criteria and would greatly appreciate your feedback.
Current implementation of train.py does not see either of these values interact, and are used solely for their respective gradient generation. With the goal of setting criteria for creation of a checkpoint, it would seem we want to look for a low perceptual loss, and simultaneously high discriminator loss, which is not quite straightforward. Other posts I've seen state that the goal is equilibrium. In which case, a decrease in deviation by x of last y points might be a route to go? Any help or insight would be greatly appreciated. |
https://github.com/krasserm/super-resolution/blob/master/train.py#L132
The GAN model training is long, and easily dies. Without checkpoints, everything has to restart. Thanks.
The text was updated successfully, but these errors were encountered: