Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for joining labels into alerts from kube_XXX_labels metrics #791

Open
primeroz opened this issue Sep 14, 2022 · 4 comments · May be fixed by #961
Open

Add support for joining labels into alerts from kube_XXX_labels metrics #791

primeroz opened this issue Sep 14, 2022 · 4 comments · May be fixed by #961
Labels
keepalive Use to prevent automatic closing

Comments

@primeroz
Copy link

primeroz commented Sep 14, 2022

For alerts routing we need to join an owner label from the kube_(pods|deployment|statefulset|xxx)_labels metrics

I was trying to find a good way to add this to upstream (here ) in a backward compatible and opt-in mode.

here is draft PR to see if we can start a conversation around this

example of Rendering is in the PR description

@jsw1993
Copy link

jsw1993 commented Jan 30, 2023

Hoping this hasn't gone stale? Would be excited to see this added.

@primeroz
Copy link
Author

I have moved on a new place since opening this up and , unfortunately, no jsonnet here.

I will have a look and turn it into a proper pr but if anyone wants to pick it up feel free.

@adberger adberger linked a pull request Jul 22, 2024 that will close this issue
Copy link

This issue has not had any activity in the past 30 days, so the
stale label has been added to it.

  • The stale label will be removed if there is new activity
  • The issue will be closed in 7 days if there is no new activity
  • Add the keepalive label to exempt this issue from the stale check action

Thank you for your contributions!

@github-actions github-actions bot added the stale label Sep 21, 2024
@adberger
Copy link

There is a pending PR, please do not close this issue!

@github-actions github-actions bot removed the stale label Sep 22, 2024
@skl skl added the keepalive Use to prevent automatic closing label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keepalive Use to prevent automatic closing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants