Support set nfs readahead in PV attributes #1162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tydra-wang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
huww98
reviewed
Sep 9, 2024
| // nfs-utils versions later than nfs-utils-2.3.3-57.0.1.al8.1 have udev rules for nfsrahead enabled, | ||
| // which automatically set a default read_ahead_kb after the bdi subsystem add event. | ||
| // To avoid conflicts, we need to introduce a delay and then recheck our custom settings. | ||
| time.Sleep(time.Second * 2) |
There was a problem hiding this comment.
This seems fighting with udev. Maybe we should find a better way.
tydra-wang
force-pushed
the
feat-nfs-readahead
branch
from
8745ecf
to
6ca20c3
Compare
k8s-ci-robot
added
the
needs-rebase
tydra-wang
force-pushed
the
feat-nfs-readahead
branch
from
6ca20c3
to
1b9b9f7
Compare
k8s-ci-robot
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: