Tune disk related sidecar client-side flow control #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huww98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
huww98
changed the title
k8s-ci-robot
added
the
needs-rebase
We should consider the default quota of ECS OpenAPI. The current quota for AttachDisk/DetachDisk is 500/60s. Each cycle needs 4-6 API call: attach: - patch PV finalizer (first attach) - patch VolumeAttachment finalizer - patch VolumeAttachment status detach: - patch VolumeAttachment status - patch VolumeAttachment finalizer - patch PV finalizer (when PV terminating) We set the qps of csi-attacher to 50 to support at least 500/60s attach+detach operations. This is 10x of the default config.
We should consider the default quota of ECS OpenAPI. The current quota for CreateDisk/DeleteDisk is 500/60s. Each cycle needs 3 API call: create: - create PV delete: - delete PV - patch PV finalizer We set the qps of csi-attacher to 25 to support 500/60s create+delete operations. This is 5x of the default config.
huww98
force-pushed
the
disk-sidecar-qps
branch
from
bcbb91f
to
493b04f
Compare
k8s-ci-robot
added
size/S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Tune disk related sidecar client-side flow control. See commit message for detail.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: