disk/snapshot: wait for cut #1225
Open
+696
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huww98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
huww98
force-pushed
the
disk-wait-snap
branch
2 times, most recently
from
8d54165
to
26a8d22
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
A central place for all disks pending status changes (attaching/detaching). Waiter will poll disk status in batch and wake up the caller if the status has changed. The motivation is reducing OpenAPI call count, to avoid triggering throttling, thus improve system throughput. Also include a simple fallback waiter to support multi-tanent use-case. Shared disk support is best effort, since we cannot create new shared disks for test now. Note: We have observed that after AttachDisk returns, the status remains Available for a short period, so don't rely on disk.Status in pred.
to support disk and snapshot with the same codebase.
should be reverted once we have a ecsClient that can refresh its credentials
CSI expect us to return the latest info each time CreateSnapshot is called.
Also retrieves the latest info about the snapshot, e.g. readyToUse.
We have client token now, and we will not create multiple snapshots for one VS object. And we still always describe snapshot at least once, so we sill have the latest info about it.
huww98
force-pushed
the
disk-wait-snap
branch
from
26a8d22
to
0cad968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
CSI requires us to ensure the snapshot is cut before returning. Implementing this by describe the just created snapshot and ensure its CreationTime is set.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: