Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firewall check "__" double underscore names for GLSL variant code generators #19

Open
kwokcb opened this issue Nov 6, 2022 · 0 comments
Open

Firewall check "__" double underscore names for GLSL variant code generators #19

kwokcb opened this issue Nov 6, 2022 · 0 comments
Labels
defect Defect in current code MaterialX

Comments

@kwokcb
Copy link
Owner

kwokcb commented Nov 6, 2022

It's still possible to create invalid shader declaration names such as "__".
Ideally this should be handled in code gen for GLSL variants as these are illegal.
The prevent can occur on the import side as well.
@kwokcb kwokcb added defect Defect in current code MaterialX labels Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect Defect in current code MaterialX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kwokcb