Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactoring to improve readability #22

Open
kyoncy opened this issue Jul 29, 2021 · 0 comments
Open

Code refactoring to improve readability #22

kyoncy opened this issue Jul 29, 2021 · 0 comments

Comments

@kyoncy
Copy link
Owner

kyoncy commented Jul 29, 2021

Why need refactoring

When I add hyperlinkPrefix in #21,
I thought "There are too many function dependencies..."

For instance

  • ReactMarkdownHeading component depends on parseHeadingText.
  • parseHeadingText depends on extractText.
  • extractText depends on parseText.
  • parseText depends on parseText itself...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kyoncy