Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Clean up fabric.js dependencies #10

Open
achimnol opened this issue Feb 13, 2017 · 1 comment
Open

Clean up fabric.js dependencies #10

achimnol opened this issue Feb 13, 2017 · 1 comment
Assignees

Comments

@achimnol
Copy link
Member

jsdom and nodecanvas causes a lot of compatibility problems with C++ compilers and latest NodeJS versions.
Let's use a custom build like:
image

After download the dev-build, we need to also remove extra require(...) calls so that webpack does not get confused with unused imports, and set fabric.isLikelyNode = false.

@achimnol achimnol self-assigned this Feb 13, 2017
achimnol added a commit that referenced this issue Feb 13, 2017
 * To cope with non-webpack-compatible build processes, imported
   xterm.js and fabric.js into our own "vendor" directory.

   - fabric.js is downloaded from the official customized builder
     (http://fabricjs.com/build/) and slightly modified to remove
     extra "reuqire()" calls that confuse webpack.

   - xterm.js is built from our fork (https://github.com/lablup/xterm.js)
     and the color scheme in xterm.css is modified to match our flavor.

   - In our fork of xterm.js, we have patched non-IME character inputs
     for macOS/iOS Safari.
@achimnol
Copy link
Member Author

I had to add "interaction" component to avoid errors due to undefined _getNonTransformedDimensions (which is actually defined but for some reason it's not accessible).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant