From e8947af6cc2763186359af7170683694ab1cd4e0 Mon Sep 17 00:00:00 2001 From: Gyubong Lee Date: Fri, 26 Apr 2024 06:10:00 +0000 Subject: [PATCH] fix: Fix wrong type of `rate_limit` in execute_script --- src/ai/backend/manager/api/ratelimit.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ai/backend/manager/api/ratelimit.py b/src/ai/backend/manager/api/ratelimit.py index 3f86bb9f26c..b06ea05dcbe 100644 --- a/src/ai/backend/manager/api/ratelimit.py +++ b/src/ai/backend/manager/api/ratelimit.py @@ -46,12 +46,12 @@ local visit_count = redis.call('ZCARD', namespaced_id) if id_type == "ip" then - local rate_limit = KEYS[3] + local rate_limit = tonumber(ARGV[3]) local score_threshold = rate_limit * 0.8 -- Add IP to suspicious_ips only if count is greater than score_threshold if visit_count >= score_threshold then - redis.call('ZADD', 'suspicious_ips', count, id_value) + redis.call('ZADD', 'suspicious_ips', visit_count, id_value) end end @@ -110,7 +110,7 @@ async def rlim_middleware( "ratelimit", _rlim_script, ["ip", ip_address], - [str(now), str(_rlim_window), rate_limit], + [str(now), str(_rlim_window), str(rate_limit)], ) if ret is None: remaining = rate_limit