Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RAIN-93896): Add permisssions for three ApiGateway resources #100

Merged
merged 3 commits into from
Oct 8, 2024
Merged

fix(RAIN-93896): Add permisssions for three ApiGateway resources #100

merged 3 commits into from
Oct 8, 2024

Conversation

jjzhangjjzhang
Copy link
Contributor

@jjzhangjjzhang jjzhangjjzhang commented Oct 2, 2024 •
edited
Loading

Summary

We are missing permissions for three apigateway resources: sdk-types, base-path-mapping, usage-plans

How did you test this change?

  1. Add resources in our dev8 environment.
  2. Trigger the collection without the change.
  3. Check the log and I do see access denied errors https://onenr.io/01wZr1a64w6
  4. Run terraform apply to our test account.
  5. Trigger the collection again (The new collection started around 11am pdt on Oct 3)
    Verify that no errors on access denied
    https://onenr.io/0VjYrlO9vQ0

Issue

@jjzhangjjzhang jjzhangjjzhang changed the title addApiGatewayPermission fix(RAIN-93896): Add permisssions for three ApiGateway resources Oct 3, 2024
@jjzhangjjzhang jjzhangjjzhang marked this pull request as ready for review October 3, 2024 19:29
@abhiram-m-kaushik-lw
Copy link

Summary

We are missing permissions for three apigateway resources: sdk-types, base-path-mapping, usage-plans

How did you test this change?

  1. Add resources in our dev8 environment.
  2. Trigger the collection without the change.
  3. Check the log and I do see access denied errors https://onenr.io/0VjYrlO9vQ0
  4. Run terraform apply to our test account.
  5. Trigger the collection again (The new collection started around 11am pdt on Oct 3)
    Verify that no errors on access denied
    https://onenr.io/0VjYrlO9vQ0

Issue

You test and results NR links are incorrect @jjzhangjjzhang

@jjzhangjjzhang
Copy link
Contributor Author

updated the url in the step 3

@jjzhangjjzhang jjzhangjjzhang merged commit cef9183 into main Oct 8, 2024
11 checks passed
@jjzhangjjzhang jjzhangjjzhang deleted the ApigatewayPermission branch October 8, 2024 20:08
@lacework-releng lacework-releng mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhiram-m-kaushik-lw abhiram-m-kaushik-lw abhiram-m-kaushik-lw approved these changes

@akshara-lw akshara-lw akshara-lw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjzhangjjzhang @abhiram-m-kaushik-lw @akshara-lw