Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add anthropic_joke_example.py in the cookbook #946

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add anthropic_joke_example.py in the cookbook #946

wants to merge 3 commits into from

Conversation

RS-labhub
Copy link

@RS-labhub RS-labhub commented Nov 11, 2024 •
edited
Loading

Fixes #882

@vercel Vercel
Copy link

vercel bot commented Nov 11, 2024

@RS-labhub is attempting to deploy a commit to the langfuse Team on Vercel.

A member of the Team first needs to authorize it.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@RS-labhub
Copy link
Author

@marcklingen you may review this

(sorry for the late PR, was busy in the festival)

marcklingen
marcklingen requested changes Nov 11, 2024
View reviewed changes
Copy link
Member

@marcklingen marcklingen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR.

How does this example integrate with Langfuse? For traceability in Langfuse you need to wrap the anthropic sdk with the Langfuse observe decorator. See this notebook for an example using Mistral SDK: https://github.com/langfuse/langfuse-docs/blob/main/cookbook/integration_mistral_sdk.ipynb

@RS-labhub
Copy link
Author

Ahh sorry, I ran down into some confusion. Will be fixing it. Sorry 😅

@marcklingen
Copy link
Member

sounds good, thank you!

@RS-labhub RS-labhub marked this pull request as draft November 12, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcklingen marcklingen marcklingen requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add anthropic_joke_example.py in the cookbook
3 participants
@RS-labhub @CLAassistant @marcklingen