Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add downstream nodes of this branch #9640

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix: add downstream nodes of this branch #9640

merged 1 commit into from
Oct 22, 2024

Conversation

linfey90
Copy link
Contributor

@linfey90 linfey90 commented Oct 22, 2024 •
edited by laipz8200
Loading

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

When there are if nodes, multiple answer nodes will be output because the branch that does not meet the if condition only excludes the next node, not the nodes of the entire downstream branch, this pr fixed it.
image

Fixes #9560

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Oct 22, 2024
laipz8200
laipz8200 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you a lot!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 22, 2024
@laipz8200 laipz8200 merged commit 999d3f1 into langgenius:main Oct 22, 2024
6 checks passed
@laipz8200 laipz8200 mentioned this pull request Oct 23, 2024
Merged
@Hisir0909
Copy link
Contributor

This doesn't seem to be solved, there's still a bug on 0.11.0

@laipz8200
Copy link
Member

This doesn't seem to be solved, there's still a bug on 0.11.0

This PR would cause another issue, so it has been reverted.

idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
@linfey90 @JunXu01
fix: add downstream nodes of this branch (langgenius#9640)
0d3a076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laipz8200 laipz8200 laipz8200 approved these changes

@takatost takatost Awaiting requested review from takatost

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Errors produced by Answer nodes and IF nodes
3 participants
@linfey90 @Hisir0909 @laipz8200