From 27139204baeac7793d28302145dee315de7238e5 Mon Sep 17 00:00:00 2001
From: larscom <larskniep@gmail.com>
Date: Sun, 22 Dec 2024 11:14:45 +0100
Subject: [PATCH] add notification

---
 .../download-artifacts-icon.component.html    |  2 +-
 .../download-artifacts-icon.component.ts      | 33 +++++++++++--------
 2 files changed, 21 insertions(+), 14 deletions(-)

diff --git a/src/app/groups/group-tabs/feature-tabs/components/download-artifacts-icon/download-artifacts-icon.component.html b/src/app/groups/group-tabs/feature-tabs/components/download-artifacts-icon/download-artifacts-icon.component.html
index dafa85d..fef35fe 100644
--- a/src/app/groups/group-tabs/feature-tabs/components/download-artifacts-icon/download-artifacts-icon.component.html
+++ b/src/app/groups/group-tabs/feature-tabs/components/download-artifacts-icon/download-artifacts-icon.component.html
@@ -16,7 +16,7 @@
       <li nz-menu-item>
         <button
           [nzLoading]="loading()"
-          (click)="download(job)"
+          (click)="download($event, job)"
           [style.color]="job.status | statusColor"
           nz-button
           nzType="link"
diff --git a/src/app/groups/group-tabs/feature-tabs/components/download-artifacts-icon/download-artifacts-icon.component.ts b/src/app/groups/group-tabs/feature-tabs/components/download-artifacts-icon/download-artifacts-icon.component.ts
index 4657946..0ad2f61 100644
--- a/src/app/groups/group-tabs/feature-tabs/components/download-artifacts-icon/download-artifacts-icon.component.ts
+++ b/src/app/groups/group-tabs/feature-tabs/components/download-artifacts-icon/download-artifacts-icon.component.ts
@@ -2,15 +2,16 @@ import { Job } from '$groups/model/job'
 import { PipelineId } from '$groups/model/pipeline'
 import { ProjectId } from '$groups/model/project'
 import { CommonModule } from '@angular/common'
-import { HttpClient } from '@angular/common/http'
+import { HttpClient, HttpErrorResponse, HttpStatusCode } from '@angular/common/http'
 import { ChangeDetectionStrategy, Component, HostListener, inject, Injector, input, signal } from '@angular/core'
 import { toObservable, toSignal } from '@angular/core/rxjs-interop'
 import FileSaver from 'file-saver'
 import { NzButtonModule } from 'ng-zorro-antd/button'
 import { NzDropDownModule } from 'ng-zorro-antd/dropdown'
 import { NzIconModule } from 'ng-zorro-antd/icon'
+import { NzNotificationService } from 'ng-zorro-antd/notification'
 import { NzToolTipModule } from 'ng-zorro-antd/tooltip'
-import { combineLatest, switchMap } from 'rxjs'
+import { combineLatest, finalize, switchMap } from 'rxjs'
 import { StatusColorPipe } from '../../pipes/status-color.pipe'
 
 @Component({
@@ -23,6 +24,7 @@ import { StatusColorPipe } from '../../pipes/status-color.pipe'
 export class DownloadArtifactsIconComponent {
   private http = inject(HttpClient)
   private injector = inject(Injector)
+  private notification = inject(NzNotificationService)
 
   projectId = input.required<ProjectId>()
   pipelineId = input.required<PipelineId>()
@@ -47,7 +49,9 @@ export class DownloadArtifactsIconComponent {
     { initialValue: [] }
   )
 
-  download({ id, name }: Job) {
+  download(e: MouseEvent, { id, name }: Job) {
+    e.stopPropagation()
+
     const params = {
       project_id: this.projectId(),
       job_id: id
@@ -55,16 +59,19 @@ export class DownloadArtifactsIconComponent {
 
     this.loading.set(true)
 
-    this.http.get('/api/artifacts', { params, responseType: 'blob' }).subscribe({
-      next: (blob) => {
-        this.loading.set(false)
-        FileSaver.saveAs(blob, `${name}_${id}.zip`)
-      },
-      error: (e) => {
-        this.loading.set(false)
-        console.error('error download file', e)
-      }
-    })
+    this.http
+      .get('/api/artifacts', { params, responseType: 'blob' })
+      .pipe(finalize(() => this.loading.set(false)))
+      .subscribe({
+        next: (blob) => FileSaver.saveAs(blob, `${name}_${id}.zip`),
+        error: ({ status, error }: HttpErrorResponse) => {
+          if (status === HttpStatusCode.NotFound) {
+            this.notification.error('Not Found', `Failed to download artifact, it's missing from the server`)
+          } else {
+            this.notification.error(`Error ${status}`, error ? error.message : 'Failed to download artifact')
+          }
+        }
+      })
   }
 
   @HostListener('click', ['$event']) onClick(e: MouseEvent) {