Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logo in self-hosted variant. #42

Open
nbeirne opened this issue Dec 8, 2024 · 2 comments
Open

Fix logo in self-hosted variant. #42

nbeirne opened this issue Dec 8, 2024 · 2 comments

Comments

@nbeirne
Copy link
Contributor

nbeirne commented Dec 8, 2024

I have started to self-host obligator. I found that the logo is broken when using the Dockerfile as provided, with no config able to fix it.

I was able to fix it for my own use, here: main...nbeirne:obligator:fix-logo-svg. I don't think this fix is acceptable for other people, though. I basically just copy the obligator logo into the docker container, at the static path.

I suppose an alternate fix is to fix LogoPng in the config, then use a docker volume for the static assets. I think it would make sense to fix it for people if they just want to pull the docker image without needing extra configuration, though.

I don't mind making attempting to fix it myself, but I do want your opinion as the maintainer on how you would prefer to do so.

@anderspitman
Copy link
Collaborator

I'm not opposed to just using the SVG. Are there any potential pitfalls to that approach? Last time I checked some browsers have issues with SVG favicons, but the logo should be fine.

@nbeirne
Copy link
Contributor Author

nbeirne commented Dec 12, 2024

I'm not a web developer, so honestly I have no idea. My biggest worry is breaking other people's configurations and your real production setup. I can open my changes a PR if you like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants