Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certificate pinning is an outdated security measure #657

Open
fs111 opened this issue Aug 31, 2023 · 0 comments
Open

certificate pinning is an outdated security measure #657

fs111 opened this issue Aug 31, 2023 · 0 comments

Comments

@fs111
Copy link

fs111 commented Aug 31, 2023

I noticed the commits regarding the certificate updates. Certificate pinning is an outdated technique and should be avoided. With proper CAA records in combination with Certificate transparency logs pinning can be avoided.

lastpass.com does have CAA records. It looks like you could further lock it down by adding CAA records to sub-domains, which would only allow globalsign to be used for lastpass.com

$ doggo CAA lastpass.com @9.9.9.9
NAME         	TYPE	CLASS	TTL 	ADDRESS                       	NAMESERVER
lastpass.com.	CAA 	IN   	300s	0 issue "amazon.com"          	9.9.9.9:53
lastpass.com.	CAA 	IN   	300s	0 issue "globalsign.com"      	9.9.9.9:53
lastpass.com.	CAA 	IN   	300s	0 iodef                       	9.9.9.9:53
             	    	     	    	"mailto:domain@lastpass.com"
lastpass.com.	CAA 	IN   	300s	0 issue "digicert.com"        	9.9.9.9:53

The ct logs are visible here https://crt.sh/?q=lastpass.com

Please consider removing the certificate pinning code to avoid downstream users having to compile things from source every time the certificates are rotated and their package manangers have not caught up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant