Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add \protected status to \begin #1438

Open
josephwright opened this issue Aug 12, 2024 · 4 comments · Fixed by #1492
Open

Add \protected status to \begin #1438

josephwright opened this issue Aug 12, 2024 · 4 comments · Fixed by #1492
Assignees
Labels
enhancement fixed in dev Fixed in development branch, not in stable release

Comments

@josephwright
Copy link
Member

As part of #1431, we may to handle \begin tokens at the start of tabular cells. Currently, the underlying \halign will expand such tokens to \protect \begin[space], meaning that any token-by-token code has to either 'reapply' the protect mechanism or handle both \begin and \begin[space]. If \begin is made engine-protected, this is not an issue as the token does not expand here.

@josephwright josephwright added this to the Release 2024 Fall milestone Aug 12, 2024
@josephwright josephwright self-assigned this Aug 12, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity.

@josephwright
Copy link
Member Author

I'm doing some testing: key question for me is will we want rollback?

@FrankMittelbach
Copy link
Member

Not sure, I can't see that it makes a difference -- a real need for a rollback seems unlikely. I think it is probably ok without, but let's hear other opinions.

@davidcarlisle
Copy link
Member

I don't think a rollback is needed begin has had a lot of changes making it \protect robust, adding all the hook code etc and has a rollback to a classic 0000/00/00 as well as not robust in 2019/10/01 and no hooks 2020/10/01 so this last change can I think be handled as an in-place update to the last change it seems unlikely there is a lot of existing third party code relying on exactly this version.

@josephwright josephwright linked a pull request Oct 12, 2024 that will close this issue
7 tasks
@josephwright josephwright added the fixed in dev Fixed in development branch, not in stable release label Oct 13, 2024
@josephwright josephwright reopened this Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement fixed in dev Fixed in development branch, not in stable release
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants