Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LD relay fails to reconnect to Redis after Redis restarts #207

Closed
carlosjgp opened this issue Dec 1, 2022 · 5 comments
Closed

LD relay fails to reconnect to Redis after Redis restarts #207

carlosjgp opened this issue Dec 1, 2022 · 5 comments

Comments

@carlosjgp
Copy link

https://support.launchdarkly.com/hc/en-us/requests/new

Describe the bug
LD relay fails to connect to Redis after Redis has restarted

To reproduce

  • Install LD relay Helm chart
  • Install Bitnami Redis chart version 16.5.0
architecture: standalone
master:
  persistence:
    enabled: false
    medium: Memory
    sizeLimit: 30Mi

Expected behavior
Fast automatic recovery whether this is fallback to "relay without store" or reconnect to Redis

Logs
If applicable, add any log output related to your problem.
image

SDK version

  • NodeJSClient_6.4.1
  • PythonClient_7.5.1

Language version, developer tools
N/A

OS/platform

  • LaunchDarkly relay version 6.7.14

Additional context
possibly related to redis/go-redis#1737

Using Sentinel could mitigate this
#114

@cwaldren-ld
Copy link
Contributor

Hi @carlosjgp, really appreciate this report. We'll look into it and get back to you.

Filed internally as 178424.

@keelerm84
Copy link
Member

@carlosjgp in your report when you mention "after Redis has restarted", how exactly were you simulating that? Scaling the stateful set back down and up again shows the relay reconnecting appropriately.

@carlosjgp
Copy link
Author

@carlosjgp in your report when you mention "after Redis has restarted", how exactly were you simulating that? Scaling the stateful set back down and up again shows the relay reconnecting appropriately.

@keelerm84 you can just terminate the POD

kubectl delete po -n <namespace> <redis master pod>

or as you mention

kubectl -n <namespace> scale statefulset <redis-master-sts> --replicas 0 

and after a while --replicas 1

@keelerm84
Copy link
Member

Hmmm, I have tried reproducing this with both options, and each worked as expected with the relay re-establishing connection to the redis instance.

You state that the relay fails to reconnect; looking at yours logs, can you confirm if it successfully establishes connection initially before restarting redis?

How are you installing the redis helm chart? Are you using the default parameters, or are you overriding some of them, like the password? And how are you injecting that information in the relay proxy helm chart?

@keelerm84
Copy link
Member

Closing due to inactivity. Please feel free to re-open if you continue experiencing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants