Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight data should distinguish bindings even in case of state rollback #9

Open
david-christiansen opened this issue Mar 21, 2024 · 0 comments

Comments

@david-christiansen
Copy link
Collaborator

Currently, when an example contains an error or when the user asks for it, we roll back the elaborator state after an example.

This is generally the right thing, but it has one downside: the unique variable counter gets reset, and later elaborator runs might re-use internal IDs. This can lead to mistaken extra highlights:

Screenshot 2024-03-21 at 11 05 12

There should be some way of preventing this, e.g. by postprocessing the elaborated example to extract the highest ID, then bumping the counter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant