Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xstream-595 typescript 5 migration + eslint 8 #567

Merged
merged 1 commit into from
Sep 17, 2024
Merged

xstream-595 typescript 5 migration + eslint 8 #567

merged 1 commit into from
Sep 17, 2024

Conversation

fatb38
Copy link
Collaborator

@fatb38 fatb38 commented Sep 17, 2024 •
edited
Loading

Checklist

Definition Of Review

  • Own code review done (add notes for others)
  • Write message in teams channel

Definition Of Mergeable

  • 2 approves
  • 1 functional review - US has been tested
  • Every comment is handled - blocking ones have been resolved by reviewer
  • Design OK
  • Can be tested by POs
  • PR was introduced during daily meeting

renaudAmsellem
renaudAmsellem approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@renaudAmsellem renaudAmsellem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@fatb38 fatb38 merged commit c260a6f into develop Sep 17, 2024
29 checks passed
@fatb38 fatb38 deleted the refacto/xstream-595-typescript-5-migration branch September 17, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippechevieux philippechevieux philippechevieux approved these changes

@TdyP TdyP TdyP approved these changes

@renaudAmsellem renaudAmsellem renaudAmsellem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fatb38 @renaudAmsellem @TdyP @philippechevieux