Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explorer Settings Side Panel #610

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Explorer Settings Side Panel #610

merged 1 commit into from
Nov 13, 2024

Conversation

P0ppoff
Copy link
Collaborator

@P0ppoff P0ppoff commented Nov 8, 2024 •
edited
Loading

Checklist

Definition Of Review

  • Own code review done (add notes for others)
  • Write message in teams channel 
     <Title>

*️⃣ Impacted projects : Core - DataStudio - Admin - @leav/ui - @leav/utils - ...

📖 Ticket: https://aristid.atlassian.net/browse/<JIRA_TICKET_IDENTIFIER>

🧑‍💻 PR: <link to PR/MR>

ℹ Info: <brief explanation - context - how to test>

Definition Of Mergeable

  • 2 approves
  • 1 functional review - US has been tested
  • Every comment is handled - blocking ones have been resolved by reviewer
  • Design OK
  • Can be tested by POs
  • PR was introduced during daily meeting

P0ppoff
P0ppoff commented Nov 8, 2024
View reviewed changes
libs/ui/package.json Outdated Show resolved Hide resolved
@P0ppoff P0ppoff force-pushed the feature/XSTREAM_936_explorerSidePanel branch from 29fff85 to d686dea Compare November 8, 2024 17:34
@TdyP TdyP changed the title --wip-- [skip ci] Explorer Settings Side Panel Nov 12, 2024
@P0ppoff P0ppoff force-pushed the feature/XSTREAM_936_explorerSidePanel branch 2 times, most recently from 2e7595a to 517c6cd Compare November 12, 2024 16:21
@P0ppoff P0ppoff force-pushed the feature/XSTREAM_936_explorerSidePanel branch 2 times, most recently from 838506b to 002f1c0 Compare November 13, 2024 09:51
@P0ppoff P0ppoff marked this pull request as ready for review November 13, 2024 09:54
@P0ppoff P0ppoff force-pushed the feature/XSTREAM_936_explorerSidePanel branch from 002f1c0 to a871648 Compare November 13, 2024 09:56
@P0ppoff P0ppoff force-pushed the feature/XSTREAM_936_explorerSidePanel branch from a871648 to eedd8d9 Compare November 13, 2024 14:51
@P0ppoff P0ppoff merged commit dee7a7f into develop Nov 13, 2024
24 checks passed
@P0ppoff P0ppoff deleted the feature/XSTREAM_936_explorerSidePanel branch November 13, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippechevieux philippechevieux philippechevieux approved these changes

@evoiron evoiron evoiron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P0ppoff @evoiron @philippechevieux