Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle multiple sorts on records query #613

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Handle multiple sorts on records query #613

merged 3 commits into from
Nov 14, 2024

Conversation

TdyP
Copy link
Contributor

@TdyP TdyP commented Nov 12, 2024 •
edited by P0ppoff
Loading

Checklist

Definition Of Review

  • Own code review done (add notes for others)
  • Write message in teams channel 
     <Title>

*️⃣ Impacted projects : Core - DataStudio - Admin - @leav/ui - @leav/utils - ...

📖 Ticket: https://aristid.atlassian.net/browse/<JIRA_TICKET_IDENTIFIER>

🧑‍💻 PR: <link to PR/MR>

ℹ Info: <brief explanation - context - how to test>

Definition Of Mergeable

  • 2 approves
  • 1 functional review - US has been tested
  • Every comment is handled - blocking ones have been resolved by reviewer
  • Design OK
  • Can be tested by POs
  • PR was introduced during daily meeting

P0ppoff
P0ppoff approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@P0ppoff P0ppoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avec @evoiron

@P0ppoff P0ppoff merged commit d10aed9 into develop Nov 14, 2024
24 checks passed
@P0ppoff P0ppoff deleted the feature/XSTREAM-982 branch November 14, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7Remy 7Remy 7Remy left review comments

@P0ppoff P0ppoff P0ppoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TdyP @P0ppoff @7Remy