Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select visible columns in settings side panel #614

Merged
merged 4 commits into from
Nov 14, 2024
Merged

select visible columns in settings side panel #614

merged 4 commits into from
Nov 14, 2024

Conversation

evoiron
Copy link
Collaborator

@evoiron evoiron commented Nov 13, 2024 •
edited
Loading

Checklist

Definition Of Review

  • Own code review done (add notes for others)
  • Write message in teams channel 
     <Title>

*️⃣ Impacted projects : Core - DataStudio - Admin - @leav/ui - @leav/utils - ...

📖 Ticket: https://aristid.atlassian.net/browse/<JIRA_TICKET_IDENTIFIER>

🧑‍💻 PR: <link to PR/MR>

ℹ Info: <brief explanation - context - how to test>

Definition Of Mergeable

  • 2 approves
  • 1 functional review - US has been tested
  • Every comment is handled - blocking ones have been resolved by reviewer
  • Design OK
  • Can be tested by POs
  • PR was introduced during daily meeting

@evoiron evoiron force-pushed the feature/XSTREAM-948_displayColumnsList branch from 1f2dbc8 to 36c20ea Compare November 14, 2024 08:30
P0ppoff
P0ppoff reviewed Nov 14, 2024
View reviewed changes
libs/ui/src/locales/en/shared.json Outdated Show resolved Hide resolved
libs/ui/src/locales/fr/shared.json Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/edit-settings/useGetLibraryColumns.ts Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/edit-settings/useGetLibraryColumns.ts Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/edit-settings/useGetLibraryColumns.ts Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/edit-settings/DisplayModeTable.tsx Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/edit-settings/DisplayModeTable.tsx Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/edit-settings/ColumnItem.tsx Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/edit-settings/ColumnItem.tsx Outdated Show resolved Hide resolved
libs/ui/src/components/Explorer/edit-settings/ColumnItem.tsx Outdated Show resolved Hide resolved
@evoiron evoiron merged commit 0ce6d58 into develop Nov 14, 2024
24 checks passed
@evoiron evoiron deleted the feature/XSTREAM-948_displayColumnsList branch November 14, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TdyP TdyP TdyP approved these changes

@P0ppoff P0ppoff P0ppoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evoiron @P0ppoff @TdyP