Tab completion stopped working for metadata

[shawkinaw]

Once upon a time, I was able to tab complete metadata tags and values, e.g. if I had a transaction like this:

2019/04/01 Albertson's
    ; Items: Milk
    Expenses:Groceries                       $100.00
    Assets:Cash

then I could later tab-complete Items and Milk, e.g.

2019/04/02 Sprouts
    ; Ite<TAB>

→

2019/04/02 Sprouts
    ; Items: <TAB>

→

2019/04/02 Sprouts
    ; Items: Milk

I believe this stopped working around the time I noticed this issue, however I'm not certain. I use metadata tags and values a lot, so losing this feature is a bit of a bummer.

[guygadebois]

Same, I recently had to move from Emacs 25 to 26 were ledger-mode changed somehow the way indentation works.
Before I was able to autocomplete on tags like ; :missing-ticket:. I could type ; :mi then TAB would autocomplete.
This is not working any more in Emacs 26 with latest ledger-mode.

Thanks in advance

[jabranham]

I won't have time the next two weeks but after that I can look into tag completion. If someone else can implement it first, please feel free to do so. :-)

…

On Thu, Nov 28, 2019, 1:27 PM Gilles Lourdelet ***@***.***> wrote: Same, I recently had to move from Emacs 25 to 26 were ledger-mode doesn't rely on flycheck any more. Before I was able to autocomplete on tags like ; :missing-ticket:. I could type ; :mi then TAB would autocomplete. This is not working any more in Emacs 26 with latest ledger-mode. Thanks in advance — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#166?email_source=notifications&email_token=AC24ZCOPQ32NFBI2IMOR3SDQWAEPXA5CNFSM4HC4SCBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNIB3A#issuecomment-559579372>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC24ZCIGRH24HYZYJNBAOTDQWAEPXANCNFSM4HC4SCBA> .

[riastradh]

The new completion system is unusable for me in its present state, so in case this is helpful for anyone else who needs to revert ledger-mode to a state where it is usable for data entry, I bisected this to 904660f.

[legalnonsense]

I just started getting into ledger and not having metadata autocomplete drove to try beancount (which also doesn't seem to do it). So here I am.

I tried going back to the above commit (beware that on Emacs 28, you have to add a third argument to the define-obsolete-function-alias call in ledger-report).

While metadata completion works, it's buggy and as there are a lot of included words that don't appear in the ledger file (probably a company config problem on my end?), capitalization is not preserved (same?) [EDIT: I found ledger-complete-ignore-case]

[purcell]

Would someone be able to try out #217 to see if it resolves the tag completion side of this?