Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ledger-default-date-format setting not respected in reports #289

Open
doolio opened this issue Feb 7, 2021 · 1 comment · May be fixed by #406
Open

ledger-default-date-format setting not respected in reports #289

doolio opened this issue Feb 7, 2021 · 1 comment · May be fixed by #406

Comments

@doolio
Copy link

doolio commented Feb 7, 2021

I've set this to match ledger-iso-date-format. The docstring ledger-default-date-format suggests the set format will be used by ledger throughout. I took this to also include reports. It does not. At a minimum I would like the report dates to include the full year e.g. 2021 vs 21.

Perhaps if/when ledger/issues/1853 is implemented this would be respected?

Thanks for your time.
bcc32 added a commit to bcc32/ledger-mode that referenced this issue Mar 18, 2024
@bcc32
ledger-report: Pass ledger-default-date-format to ledger command
e2f75fe 
Fix ledger#289
@bcc32
Copy link
Collaborator

bcc32 commented Mar 18, 2024

Yeah, it looks like reports are the one place where ledger-mode might call ledger but not go through the ledger-exec-ledger function (I guess it's because reports could be arbitrary shell commands, not just a single invocation of ledger with some args).

(I don't think the ledger-cli issue is related.)

@bcc32 bcc32 linked a pull request Mar 18, 2024 that will close this issue
Open
bcc32 added a commit to bcc32/ledger-mode that referenced this issue Mar 21, 2024
@bcc32
ledger-report: Pass ledger-default-date-format to ledger command
060624b 
Fix ledger#289
bcc32 added a commit to bcc32/ledger-mode that referenced this issue Apr 23, 2024
@bcc32
ledger-report: Pass ledger-default-date-format to ledger command
ab1a951 
Fix ledger#289
bcc32 added a commit to bcc32/ledger-mode that referenced this issue Jul 9, 2024
@bcc32
report-use-default-date-format
620be7a 
commit ab1a951
Author: Aaron L. Zeng <me@bcc32.com>
Date:   Mon Mar 18 16:37:07 2024 -0400

    ledger-report: Pass ledger-default-date-format to ledger command

    Fix ledger#289
bcc32 added a commit to bcc32/ledger-mode that referenced this issue Jul 22, 2024
@bcc32
report-use-default-date-format
cf6f577 
commit ab1a951
Author: Aaron L. Zeng <me@bcc32.com>
Date:   Mon Mar 18 16:37:07 2024 -0400

    ledger-report: Pass ledger-default-date-format to ledger command

    Fix ledger#289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ledger-report: Pass ledger-default-date-format to ledger command bcc32/ledger-mode
2 participants
@bcc32 @doolio