Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradient-based minimization and gradients #66

Open
LisaSchlueter opened this issue Aug 13, 2024 · 2 comments · May be fixed by #73
Open

Gradient-based minimization and gradients #66

LisaSchlueter opened this issue Aug 13, 2024 · 2 comments · May be fixed by #73
Assignees
Labels
enhancement New feature or request

Comments

@LisaSchlueter
Copy link
Contributor

The default algorithm of the Optim minimizer is Nelder-Mead(), which is a gradient-free method. I'd like to explore gradient-based algorithms, such as GradientDescent() or LBFGS().
Motivation:

  • We sometimes get weird fit results of calibration gamma peaks
  • When testing combined fits or comparing the different peakshape-models, the fit sometimes unreliable (local minimum?)
  • Choice of some pseudo-prior (e.g. skew fraction) have unrealistic strong impact on fit result

When going to a gradient-based algorithm, it would make sense to provide the minimizer with the analytical gradients. @oschulz
do you have experience on how to do that in julia?

@oschulz
Copy link
Contributor

oschulz commented Aug 14, 2024

In principle we can used automatic differentiation (ForwardDiff if it's just a handful of parameters) to enable LBFGS and so on. But we have to make sure the Likelihood is differentiable in principle, but for fitting a function to a histograms that's typically not a problem.

@theHenks theHenks added the enhancement New feature or request label Aug 14, 2024
@fhagemann
Copy link
Contributor

This does not work for multithreaded code.

@theHenks theHenks linked a pull request Sep 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants