Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes in LQ cut #64

Open
6 tasks
theHenks opened this issue Aug 8, 2024 · 1 comment · May be fixed by #74
Open
6 tasks

Bug fixes in LQ cut #64

theHenks opened this issue Aug 8, 2024 · 1 comment · May be fixed by #74
Assignees
@theHenks
Labels
bug Something isn't working enhancement New feature or request

Comments

@theHenks
Copy link
Collaborator

theHenks commented Aug 8, 2024 •
edited
Loading

Bug fixes in LQ cut method needed:

  • - Rename lq_mode in surrival fraction extractor to inverted
  • - Make lq functions type stable in arguments
  • - Remove hard coded detector type and introduce generic functions for fit w/o double gaussian etc.
  • - Cleaner error handling
  • - Report and result similar to other methods with plot recipe for report
  • - Include func string which can be read by ljlpropfunc to generate corrected lq values out of dsp table
@theHenks
Copy link
Collaborator Author

theHenks commented Aug 8, 2024

CC @DaGeibl

@theHenks theHenks self-assigned this Aug 8, 2024
@theHenks theHenks added bug Something isn't working enhancement New feature or request labels Aug 8, 2024
@theHenks theHenks linked a pull request Oct 5, 2024 that will close this issue
Lq updated #74
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theHenks theHenks

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lq updated DaGeibl/LegendSpecFits.jl
1 participant
@theHenks