Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

CAS Server Package #1

Open
loren138 opened this issue Aug 12, 2016 · 1 comment
Open

CAS Server Package #1

loren138 opened this issue Aug 12, 2016 · 1 comment

Comments

@loren138
Copy link

Hi Leo,

I'm not sure if this is an option for your right now, but I've been working on a CAS Server Laravel Package (https://github.com/loren138/cas-server) which implements a lot of the same things you have (with the exception of warn). I think your implementation has a better design pattern than mine overall also.

Anyway, I was wondering if you would have any interest in trying to merge your implementation with mine as a package such that it would be easier to distribute and have other people contribute to.

Without it being a package, adding a new feature (such as Proxy) could cause a large amount of merge conflicts if people have cloned the full laravel instance and then altered the own views/added some of their own packages.

@leo108
Copy link
Owner

leo108 commented Aug 13, 2016

I had considered about this project should be a stand alone project or a package, finally I choose to create a stand alone project just because it's weird for a package to have an admin area.
I have just reconsidered about it, I think my project can be divided into two projects, one focuses on implement CAS protocol and be a package, another focuses on UI/admin area and be a stand alone project depends on the first one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants