Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added travisCI SIMDe example for arm64 + fix to Makefile for SIMDe #604

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mbrcic
Copy link
Contributor

@mbrcic mbrcic commented May 11, 2020

Reproductive command steps for arm64 minimap2 using SIMDe, as asked in:
#597

In process, I have fixed an error in Makefile.simde that probably appeared during the merge of previous PR.

@mbrcic mbrcic changed the title Added travisCI example + fix to Makefile for SIMDe Added travisCI SIMDe example for arm64 + fix to Makefile for SIMDe May 11, 2020
@junaruga
Copy link
Contributor

Thanks! awesome! Let's wait @lh3 's response.

.travis.yml Outdated
@@ -10,6 +10,10 @@ matrix:
language: c
compiler: gcc
script: make arm_neon=1 aarch64=1
arch: arm64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line's syntax is wrong. You need -.

    - arch: arm64

Copy link
Contributor

@junaruga junaruga May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the result of the CI: https://travis-ci.org/github/lh3/minimap2/builds/685858196 . There are total 6 jobs. But it has to be total 7 jobs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, sorry, IDE issues :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with that syntax mistake, the file is parsed in such a way that arm64 config takes only one (the last) variable values. you can check the parsed values with validator: https://config.travis-ci.com/explore
when that - is put in place, it parses well and there should be 7 tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know the config validation page. Thanks for sharing.
Yeah, now total 7 jobs here. https://travis-ci.org/github/lh3/minimap2/builds/685864104

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we use name: syntax in .travis.yml, technically we can distinguish the similar jobs by the job names on the CI page. But I assume Heng likes the minimum config, and does not like the name syntax. So, maybe the current config is okay.

@mbrcic
Copy link
Contributor Author

mbrcic commented May 11, 2020

With this syntax mistake fixed, travisCI should do 7 tests, twice on arm64.

Makefile.simde Outdated
@@ -6,6 +6,7 @@ OBJS= kthread.o kalloc.o misc.o bseq.o sketch.o sdust.o options.o index.o chain
PROG= minimap2
PROG_EXTRA= sdust minimap2-lite
LIBS= -lm -lz -lpthread
SSE4=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the tailing space (tab) here. It's better to remove it.

Copy link
Contributor Author

@mbrcic mbrcic May 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. Should this fixing commit be squashed as well?

@junaruga
Copy link
Contributor

I think it's better to unify this PR's 2 commits to 1 commit by doing squash. (such as git rebase -i <commit hash>).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants