From 4d20d08080d4e891bbad9e0c9797f400619756d6 Mon Sep 17 00:00:00 2001 From: Eric Warmenhoven Date: Tue, 10 Sep 2024 15:03:04 -0400 Subject: [PATCH] fix to avoid reacquiring a mutex reentrantly (#16985) --- gfx/gfx_widgets.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gfx/gfx_widgets.c b/gfx/gfx_widgets.c index be9301c310d..d7e79d50fa4 100644 --- a/gfx/gfx_widgets.c +++ b/gfx/gfx_widgets.c @@ -243,8 +243,6 @@ void gfx_widgets_msg_queue_push( if (task) { - uint8_t flg = task_get_flags(task); - title = msg_widget->msg = strdup(task->title); msg_widget->msg_new = strdup(title); title_length = strlen(title); @@ -252,9 +250,9 @@ void gfx_widgets_msg_queue_push( if (!string_is_empty(task->error)) msg_widget->flags |= DISPWIDG_FLAG_TASK_ERROR; - if ((flg & RETRO_TASK_FLG_CANCELLED) > 0) + if ((task->flags & RETRO_TASK_FLG_CANCELLED) > 0) msg_widget->flags |= DISPWIDG_FLAG_TASK_CANCELLED; - if ((flg & RETRO_TASK_FLG_FINISHED) > 0) + if ((task->flags & RETRO_TASK_FLG_FINISHED) > 0) msg_widget->flags |= DISPWIDG_FLAG_TASK_FINISHED; msg_widget->task_progress = task->progress; msg_widget->task_ident = task->ident;