Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildbot emscripten cores do not have async support #15545

Closed
JoeOsborn opened this issue Aug 3, 2023 · 1 comment · Fixed by #15559
Closed

Buildbot emscripten cores do not have async support #15545

JoeOsborn opened this issue Aug 3, 2023 · 1 comment · Fixed by #15559

Comments

@JoeOsborn
Copy link
Contributor

It looks like none of the emscripten cores in https://buildbot.libretro.com/nightly/emscripten/ are compiled with the correct emscripten flags. A quick text search through e.g. fceumm_libretro.js for emscripten_sleep shows that it just throws an exception ("Please compile your program with async support") rather than sleeping. Async support seems to be required since #15479. My guess is that the core makefiles aren't passing along the right flags?

The web player at web.libretro.com also seems busted, in that retroarch won't seem to boot into the menu for the fceumm core in Linux Firefox or Chromium. I don't know if this is a related issue.

@JoeOsborn
Copy link
Contributor Author

I think the fix here is to default ASYNC to 1 instead of 0 in Retroarch’s Makefile.emscripten, possibly only if HAVE_OPENAL is 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant