Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: change openchannel to make private channels by default #9157

Open
AndySchroder opened this issue Oct 3, 2024 · 2 comments
Open
Labels
enhancement Improvements to existing features / behaviour

Comments

@AndySchroder
Copy link

AndySchroder commented Oct 3, 2024

I believe that the openchannel command should make private channels by default.

With the addition of blinded paths, I think there are a lot of nodes that won't want to announce their channel peers and one should need to make an explicit choice by default to announce channels publicly.

Of course, there should be an option in lnd.conf to change this default, but I believe that default value should be set to private by default. The autopilot feature already has this (

; Whether the channels created by the autopilot agent should be private or not.
).

Also, if we get some protocol changes and #7902 gets fixed, you could change your mind later if you want to make it public, giving a lot more flexibility to evaluate if the channel partner is a good one before announcing it (it is never going to be possible to make a protocol change to turn a public channel private). Do dynamic commitments help with making #7902 possible?

@AndySchroder AndySchroder added the enhancement Improvements to existing features / behaviour label Oct 3, 2024
@saubyk
Copy link
Collaborator

saubyk commented Oct 3, 2024

Shouldn't this be a prerogative of the applications instead?
LND has many types of users ranging from routing nodes to wallets to payment processors to exchanges. This might be preference for one cohort (wallets?), but the rest may not want it as default.

@AndySchroder
Copy link
Author

Yes, that's why I proposed the default could be something that can be set in the lnd.conf file. It seems to me like LND should default to be safe for even the most unfamiliar and new users and keeping channels private unless explicitly opting in to make them public seems to be the safest and most conservative option in my opinion. This is surely up for debate, that's why I wanted to open this issue to see what other people thought.

Even if you don't agree that the default default should be private, would you agree that each operator should be able to set their personal default to private in lnd.conf?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features / behaviour
Projects
None yet
Development

No branches or pull requests

2 participants