Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirrored repository doesn't overwrite changes pushed by users during mirroring #920

Open
minwoox opened this issue Feb 13, 2024 · 3 comments
Labels

Comments

@minwoox
Copy link
Member

minwoox commented Feb 13, 2024

When a commit is pushed to a mirrored repository, the expectation is that any changes made by users are overwritten during the next mirroring process. However, this is not happening as expected.
The root cause lies in Central Dogma's limited check, which solely examines the stored local revision—unchanged by the user's commit—against the remote head.

@minwoox minwoox added the defect label Feb 13, 2024
@thachlp
Copy link
Member

thachlp commented Feb 25, 2024

Hello @minwoox, I would like to take this issue, but still confused. Could you give me an example of what is expected and the current status, so I can try to reproduce it?

@ikhoon
Copy link
Contributor

ikhoon commented Feb 29, 2024

Say, there is Git repository A mirrored to Central Dogma repository B.
The content of A and B should be the same except for mirror_state.json. If some content is pushed to B repository, it should be overwritten by the content of A.

Currently, the changes pushed to B do not update mirror_state.json so the head revision comparison can't detect new commits in B.

We may solve the problem by storing the latest revision of B mirrored to mirror_state.json.

@thachlp
Copy link
Member

thachlp commented Mar 1, 2024

Thanks @ikhoon, I will try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants