From 272e9ea0755dd0e630581ea65cedc838a8b5e928 Mon Sep 17 00:00:00 2001 From: Chris Li Date: Wed, 1 Dec 2021 00:53:15 -0800 Subject: [PATCH] Bump up parallism.max default and max values --- .../com/linkedin/cdi/configuration/PropertyCollection.java | 2 +- .../cdi/configuration/MultistagePropertiesIndividualTest.java | 2 +- docs/parameters/ms.work.unit.parallelism.max.md | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cdi-core/src/main/java/com/linkedin/cdi/configuration/PropertyCollection.java b/cdi-core/src/main/java/com/linkedin/cdi/configuration/PropertyCollection.java index c856e9c..1571020 100644 --- a/cdi-core/src/main/java/com/linkedin/cdi/configuration/PropertyCollection.java +++ b/cdi-core/src/main/java/com/linkedin/cdi/configuration/PropertyCollection.java @@ -241,7 +241,7 @@ public Long getMillis(State state) { }; // default: 100, minimum: 0, maximum: 1000, 0 = default value - IntegerProperties MSTAGE_WORK_UNIT_PARALLELISM_MAX = new IntegerProperties("ms.work.unit.parallelism.max", 100, 1000, 0) { + IntegerProperties MSTAGE_WORK_UNIT_PARALLELISM_MAX = new IntegerProperties("ms.work.unit.parallelism.max", 500, 5000, 0) { @Override protected Integer getValidNonblankWithDefault(State state) { int value = super.getValidNonblankWithDefault(state); diff --git a/cdi-core/src/test/java/com/linkedin/cdi/configuration/MultistagePropertiesIndividualTest.java b/cdi-core/src/test/java/com/linkedin/cdi/configuration/MultistagePropertiesIndividualTest.java index 9d89c4a..687f0bd 100644 --- a/cdi-core/src/test/java/com/linkedin/cdi/configuration/MultistagePropertiesIndividualTest.java +++ b/cdi-core/src/test/java/com/linkedin/cdi/configuration/MultistagePropertiesIndividualTest.java @@ -253,7 +253,7 @@ public void testWorkUnitParallelismMax() { state.setProp("ms.work.unit.parallelism.max", "0"); Assert.assertTrue(MSTAGE_WORK_UNIT_PARALLELISM_MAX.isValid(state)); - Assert.assertEquals(MSTAGE_WORK_UNIT_PARALLELISM_MAX.get(state).intValue(), 100); + Assert.assertEquals(MSTAGE_WORK_UNIT_PARALLELISM_MAX.get(state).intValue(), 500); state.setProp("ms.work.unit.parallelism.max", "0L"); Assert.assertFalse(MSTAGE_WORK_UNIT_PARALLELISM_MAX.isValid(state)); diff --git a/docs/parameters/ms.work.unit.parallelism.max.md b/docs/parameters/ms.work.unit.parallelism.max.md index 2419801..1c00a41 100644 --- a/docs/parameters/ms.work.unit.parallelism.max.md +++ b/docs/parameters/ms.work.unit.parallelism.max.md @@ -4,9 +4,9 @@ **Type**: integer -**Default value**: 100 (value 0 will also be interpreted as 100) +**Default value**: 500 (value 0 will also be interpreted as 500) -**Max value**: 1000 +**Max value**: 5000 **Related**: