From 1d43edee1a9277324f75b4e90362dd6dc367ecdf Mon Sep 17 00:00:00 2001 From: Jagriti Madan Date: Tue, 12 Dec 2023 16:45:50 -0800 Subject: [PATCH] Rename next to nextPageToken to keep it uniform with grpc (#954) * Rename next to nextPageToken to keep it uniform with grpc * Revert "Rename next to nextPageToken to keep it uniform with grpc" This reverts commit 4c8b1ba555bfac7032fa6eeed72e43bebdc154e3. * Rename next to nextPageToken to keep it uniform with grpc * Rename next to nextPageToken to keep it uniform with grpc * Update gradle.properties --- CHANGELOG.md | 6 +++++- gradle.properties | 2 +- .../pegasus/com/linkedin/restli/common/CursorPagination.pdl | 2 +- .../com/linkedin/restli/common/CursorPagination.pdsc | 2 +- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6c18ed836b..16eebea446 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,9 @@ and what APIs have changed, if applicable. ## [Unreleased] +## [29.48.6] - 2023-12-12 +- Rename next to nextPageToken in standardized models for cursor based pagination + ## [29.48.5] - 2023-12-12 - add debug log to dual read caches @@ -5578,7 +5581,8 @@ patch operations can re-use these classes for generating patch messages. ## [0.14.1] -[Unreleased]: https://github.com/linkedin/rest.li/compare/v29.48.5...master +[Unreleased]: https://github.com/linkedin/rest.li/compare/v29.48.6...master +[29.48.6]: https://github.com/linkedin/rest.li/compare/v29.48.5...v29.48.6 [29.48.5]: https://github.com/linkedin/rest.li/compare/v29.48.4...v29.48.5 [29.48.4]: https://github.com/linkedin/rest.li/compare/v29.48.3...v29.48.4 [29.48.3]: https://github.com/linkedin/rest.li/compare/v29.48.2...v29.48.3 diff --git a/gradle.properties b/gradle.properties index f8e746d2e3..fa61d7d558 100644 --- a/gradle.properties +++ b/gradle.properties @@ -1,4 +1,4 @@ -version=29.48.5 +version=29.48.6 group=com.linkedin.pegasus org.gradle.configureondemand=true org.gradle.parallel=true diff --git a/restli-common/src/main/pegasus/com/linkedin/restli/common/CursorPagination.pdl b/restli-common/src/main/pegasus/com/linkedin/restli/common/CursorPagination.pdl index b4683af6c8..57e254e0af 100644 --- a/restli-common/src/main/pegasus/com/linkedin/restli/common/CursorPagination.pdl +++ b/restli-common/src/main/pegasus/com/linkedin/restli/common/CursorPagination.pdl @@ -9,5 +9,5 @@ record CursorPagination { * Pagination cursor that points to the end of the current page and can be used to fetch the next page. * Not populated if the current page is the last page. */ - next: optional string + nextPageToken: optional string } \ No newline at end of file diff --git a/restli-common/src/main/resources/legacyPegasusSchemas/com/linkedin/restli/common/CursorPagination.pdsc b/restli-common/src/main/resources/legacyPegasusSchemas/com/linkedin/restli/common/CursorPagination.pdsc index 45949aa27e..a9798a9256 100644 --- a/restli-common/src/main/resources/legacyPegasusSchemas/com/linkedin/restli/common/CursorPagination.pdsc +++ b/restli-common/src/main/resources/legacyPegasusSchemas/com/linkedin/restli/common/CursorPagination.pdsc @@ -4,7 +4,7 @@ "namespace" : "com.linkedin.restli.common", "doc" : "Metadata for cursor based pagination with collections.", "fields" : [ { - "name" : "next", + "name" : "nextPageToken", "type" : "string", "doc" : "Pagination cursor that points to the end of the current page and can be used to fetch the next page.\nNot populated if the current page is the last page.", "optional" : true