Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkdeclarative #205

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#435

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#435
@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

代码审查意见:

qml/ComboBox.qml 文件改动:

  • 新增的 opacity 属性在 ComboBox 组件中使用了条件表达式,这可能会导致组件在不同状态下(启用和禁用)的透明度变化。需要确认这是否符合设计要求。
  • horizontalAlignment 属性的赋值逻辑可能需要优化,当前的实现依赖于 control.flat 属性,但没有提供 control 对象的定义。如果 control 是一个外部传入的属性,需要确保在使用前已经正确初始化。

dquickiconimage.cpp 文件改动:

  • updateDevicePixelRatio 函数中新增了一个 qreal ratio 变量,用于存储当前的 devicePixelRatio 值。这个改动有助于后续的代码逻辑判断,但需要确保在所有路径中都有相应的处理,以避免潜在的逻辑错误。
  • 新增的 maybeUpdateUrl 函数调用是为了在 devicePixelRatio 发生变化时更新 URL。需要确认 maybeUpdateUrl 函数的实现是否正确,并且是否处理了所有可能的情况。

总体来说,这些改动看起来是合理的,但需要进一步确认设计要求和函数实现的正确性。

@kegechen kegechen merged commit dcb969d into master Dec 17, 2024
11 of 13 checks passed
@kegechen kegechen deleted the sync-pr-435-nosync branch December 17, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants