Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for macvtap with Firecracker #856

Open
richardcase opened this issue Jul 9, 2024 · 3 comments
Open

Remove support for macvtap with Firecracker #856

richardcase opened this issue Jul 9, 2024 · 3 comments
Assignees
Labels
kind/feature New feature or request
Milestone

Comments

@richardcase
Copy link
Member

Describe the solution you'd like:
Currently we use a forked version of Firecracker to get macvtap support. However, this feature isn't merged into main of Firecracker yet and its painful to continue to support a forked version.

Proposal:

  • Remove usage of Forked firecracker version
  • Update supported features to say macvtap is only supported with cloud hypervisor

Why do you want this feature:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@richardcase richardcase added the kind/feature New feature or request label Jul 9, 2024
@richardcase richardcase added this to the v0.7.0 milestone Jul 9, 2024
@mmchougule
Copy link

@richardcase Anyone working on this? If possible, I would like to work to clean up firecracker and macvtap support for cloud hypervisor.

@richardcase
Copy link
Member Author

@mmchougule - there is no one working on this yet, so that would be great if you wanted to work on it. I had a couple of thoughts on this that may help:

  • We could introduce a new capability that a provider says if they support for macvtap.
    • Capabilities are defined here
    • The Firecracker & CloudHypervisor could publish whether they support macvtap (Firecracker doesn't but CH does). This is done using the Capabilities function on the provider interface
    • Somewhere in the core we'd need to check that an incoming microvm create request that the network interfaces if they have macvtap defined and if the provider doesn't support it then return an error
  • There is a GHA workflow that checks for new firecracker versions and create an issue to update the fork. This can be deleted as we won't support the fork going forward
  • Do you think it would be worth still checking for new Firecracker & Cloud Hypervisor releases and creating an issue for someone to check compatibility?
  • Docs would need updating to remove mention of using the fork.

Feel free to ping me if you have any questions. We've also created a slack channel in the CNCF slack.

@richardcase
Copy link
Member Author

@mmchougule - just checking in to see if you wanted to work on this? On pressure, if you don't then i will pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants