Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to integrate latest torch-mlir with torch stable <= 2.4.0? #3674

Open
qingyunqu opened this issue Aug 29, 2024 · 3 comments
Open

How to integrate latest torch-mlir with torch stable <= 2.4.0? #3674

qingyunqu opened this issue Aug 29, 2024 · 3 comments

Comments

@qingyunqu
Copy link
Collaborator

Becuase of torch have changed the signature of aten.scale_dot_product_attention, the relative testcases failed when the torch is not latest nightly version. See also #3627 and #3666.
It's hard for me when I want to integrate latest torch-mlir with torch stable <= 2.4.0.

Is there any possible to provide compatibility? @vivekkhandelwal1 @rsuderman @stellaraccident

In short term, I think I could checkout a new branch and manually cherry pick commits which I need, until the problem have been resolved or torch==2.5.0 stable version have been released.

@stellaraccident
Copy link
Collaborator

stellaraccident commented Aug 29, 2024

We should just create a 2.4 compatible tag and upgrade head to 2.5. Torch is moving too fast to have a large at head compatibility window.

If you have a branch that is 2.5 ready, we can land that.

@stellaraccident
Copy link
Collaborator

Oh wait, in my mind, 2.5 was already released but that happens in the near future.

Shall we start a 2.5 branch in torch-mlir for the early adoption and then land it when torch releases?

I also wish we had a way to deal with these signature changes in a less disruptive way.

@qingyunqu
Copy link
Collaborator Author

Oh wait, in my mind, 2.5 was already released but that happens in the near future.

Shall we start a 2.5 branch in torch-mlir for the early adoption and then land it when torch releases?

I also wish we had a way to deal with these signature changes in a less disruptive way.

Something like tf onnx's method is to create a old version op like aten.scale_dot_product_attention_v1, both keep aten.scale_dot_product_attention_v1 and aten.scale_dot_product_attention in torch-mlir.
If do that, I think we should change jit_ir_importer and fx_importer ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants