You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Becuase of torch have changed the signature of aten.scale_dot_product_attention, the relative testcases failed when the torch is not latest nightly version. See also #3627 and #3666.
It's hard for me when I want to integrate latest torch-mlir with torch stable <= 2.4.0.
In short term, I think I could checkout a new branch and manually cherry pick commits which I need, until the problem have been resolved or torch==2.5.0 stable version have been released.
The text was updated successfully, but these errors were encountered:
Oh wait, in my mind, 2.5 was already released but that happens in the near future.
Shall we start a 2.5 branch in torch-mlir for the early adoption and then land it when torch releases?
I also wish we had a way to deal with these signature changes in a less disruptive way.
Something like tf onnx's method is to create a old version op like aten.scale_dot_product_attention_v1, both keep aten.scale_dot_product_attention_v1 and aten.scale_dot_product_attention in torch-mlir.
If do that, I think we should change jit_ir_importer and fx_importer ?
Becuase of torch have changed the signature of
aten.scale_dot_product_attention
, the relative testcases failed when the torch is not latest nightly version. See also #3627 and #3666.It's hard for me when I want to integrate latest torch-mlir with torch stable <= 2.4.0.
Is there any possible to provide compatibility? @vivekkhandelwal1 @rsuderman @stellaraccident
In short term, I think I could checkout a new branch and manually cherry pick commits which I need, until the problem have been resolved or torch==2.5.0 stable version have been released.
The text was updated successfully, but these errors were encountered: