install-jar: avoid silent swallowing of curl download failure #710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use
geopyspark install-jar
to download the backend jar, and something goes wrong with the curl command, the user doesn't really notice this.For example: I was working with a forked version of geopyspark, which had a custom version defined in
geopyspark_constants.py
. I rangeopyspark install-jar
to download the jar and that seemed to work. After losing quite some time troubleshooting, I found out that `geotrellis-backend-assembly-foobar.jar' was a very small file, just containing the text "Not Found" :/This PR addresses this by making sure an exception is raised when the download encounters 4xx or 5xx http codes so the user will know earlier that something is wrong. It also add showing the download URL and target path for easier troubleshooting