Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install-jar: avoid silent swallowing of curl download failure #710

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

soxofaan
Copy link

When you use geopyspark install-jar to download the backend jar, and something goes wrong with the curl command, the user doesn't really notice this.

For example: I was working with a forked version of geopyspark, which had a custom version defined in geopyspark_constants.py. I ran geopyspark install-jar to download the jar and that seemed to work. After losing quite some time troubleshooting, I found out that `geotrellis-backend-assembly-foobar.jar' was a very small file, just containing the text "Not Found" :/

This PR addresses this by making sure an exception is raised when the download encounters 4xx or 5xx http codes so the user will know earlier that something is wrong. It also add showing the download URL and target path for easier troubleshooting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant