Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use {pak} to parallel install with {renv} #343

Open
lorenzwalthert opened this issue Dec 10, 2021 · 5 comments
Open

use {pak} to parallel install with {renv} #343

lorenzwalthert opened this issue Dec 10, 2021 · 5 comments

Comments

@lorenzwalthert
Copy link
Owner

lorenzwalthert commented Dec 10, 2021

@pat-s offered to test with {mlr3viz}, which has a timeout because of dependency installation time > 120s. Potentially needs changes upstream in pre-commit.

@pat-s
Copy link
Contributor

pat-s commented Dec 10, 2021

@lorenzwalthert
Copy link
Owner Author

lorenzwalthert commented Dec 10, 2021

Not sure I want to opt-in into an experimental feature, in particular due to

Once we're more certain the integration is solid we'll consider turning this on by default.

Not sure what the ETA is for that. In any case, it's good to know that this is going to be the default at some point.

@pat-s
Copy link
Contributor

pat-s commented Dec 10, 2021

We could test it in a precommit branch. I thought that eventually the effort will be small as its only an option you might need to set.

Not sure how easy it would to use a precommit branch though 🙂

@lorenzwalthert
Copy link
Owner Author

This affects the installation procedure of the hooks, which is not handled by {precommit} (or any repositories that implements hooks), but in the upstream framework, i.e. here. So testing this would involve a change in the upstream, a release in the upstream at least, as we don't control the version of pre-commit that is ran on pre-commit.ci

@lorenzwalthert
Copy link
Owner Author

Locally, we could test it before by installing a development version of pre-commit from a branch (note pre-commit=upstream, {precommit} = R package).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants