Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add artifact for Apple Silicon #27

Closed
ropoko opened this issue Nov 18, 2023 · 3 comments
Closed

Add artifact for Apple Silicon #27

ropoko opened this issue Nov 18, 2023 · 3 comments

Comments

@ropoko
Copy link

ropoko commented Nov 18, 2023

The current mac-os artifact is only for x86_64, and it would be nice to have the arm64 version

@tpimh
Copy link

tpimh commented Jan 20, 2024

Definitely a good idea.

love2d/love#2008 (comment):

According to https://store.steampowered.com/hwsurvey/Steam-Hardware-Software-Survey-Welcome-to-Steam?platform=mac 70% of mac steam users have an arm64 system, so you might not want to leave that out - and your x64 library will fail to work on those systems anyway unless you strip out the arm64 part of love.app to make it use Rosetta x64 emulation.

@slime73
Copy link
Member

slime73 commented Jan 20, 2024

I want to do this, but I'd like it to be a fat binary containing both arm64 and x64 (just like love and other native apps and libraries), which probably needs a bit more fiddling with the CI setup and maybe the CMake project than otherwise.

slime73 added a commit that referenced this issue Jan 21, 2024
[#27] Add support for building universal lua-https modules.
@slime73
Copy link
Member

slime73 commented Jan 21, 2024

Done in 221bb84

@slime73 slime73 closed this as completed Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants