Puppeteer timeouts when rendering

[ferferga]

Before, I had 2 steps for metrics generation (one for the left and one for the right). I'm trying to merge them in a single step as you can see in current master (if you're an user reading this from the future, be aware I usually force push this repository, so what's currently in master will change). I tried disabling all plugins and enabling them back one by one manually and it breaks as soon as I enable the achievements one. Commenting the plugin_achievements_* config completely fixes the issue

Here's an screenshot of whats the last thing logged (GitHub seems to clear some logs from the workflow run):

Here is one of the failing workflow runs:
https://github.com/ferferga/ferferga/actions/runs/3648218293

[lowlighter]

I tried to replicate your issue and couldn't get the same unfortunately 😕

Even though I was also getting the negative rect it still rendered (I was testing in svg output though)

  metrics/svg/resize > loading svg
  metrics/svg/resize > puppeteer > Error: <rect> attribute width: A negative value is not valid. ("-2.303664921465969")
  metrics/svg/resize > puppeteer > Error: <rect> attribute width: A negative value is not valid. ("-2.8002213613724405")
  metrics/svg/resize > loaded svg successfully
  metrics/svg/resize > resizing svg
  metrics/svg/resize > puppeteer > animations are enabled
  metrics/svg/resize > puppeteer > bounds width=980, height=1045.765625
  metrics/svg/resize > puppeteer > bounds after applying padding width=980 (*1+0), height=1046 (*1+0)
  metrics/svg/resize > rendering complete
  metrics/compute/ferferga > success

I fixed the negative values and tried again in both svg and png this time and the output was succesful so I'm not sure what's causing this.

Could you try using the svg output and see if you still encouter your error ?
The achievement plugin has some CSS animations so maybe it's making the png rendering fail in some case 🤔 ?

[ferferga]

So it looks like the issue resolved itself, even without debug flags enabled. I went commit by commit to find out more hints:

• master: https://github.com/ferferga/ferferga/actions/runs/3693338901 🟢
• master (with --pupeeteer-debug enabled): https://github.com/ferferga/ferferga/actions/runs/3693455916 🟢
• latest: https://github.com/ferferga/ferferga/actions/runs/3693960368 ❌

At this point, beside the commit tag, all the tests were done also with the use_prebuilt_image: no flag

• 77fd4d0: https://github.com/ferferga/ferferga/actions/runs/3693547530 🟢
• 73c8e87: https://github.com/ferferga/ferferga/actions/runs/3693645492 🟢
• 3a4559e: https://github.com/ferferga/ferferga/actions/runs/3693741084 🟢
• a900442: https://github.com/ferferga/ferferga/actions/runs/3693814533 🟢
• latest: https://github.com/ferferga/ferferga/actions/runs/3693888049 🟢

The important thing is that now I have fully working metrics (with use_prebuilt_image: no, but better that than nothing) so thank you very much for your help 🙌.
However, I don't know how to further diagnose which commit might have fixed this, as all of them seem to pass the checks perfectly fine. My guess is that the problem exists in a dependency inside the Docker container (and that's why latest without prebuilt works but latest with prebuilt doesn't).

[lowlighter]

Yeah I think you're probably right, the latest release probably have a faulty dependency packaged in which could explain this.
Thanks a lot for looking into it, glad you solved the issue 😄

[ferferga]

Any chance you can rebuild and retag the image or shall I wait for the next update if I want to stick with latest?

[lowlighter]

I prefer releasing a new version rather than altering an already released version (even if it's broken)

#1315 is pretty high on my todo-list (planning to work on it this week-end) and I plan to make a release once it's patched so @latest should be updated in the next few days 👍

[ferferga]

@lowlighter The new release now includes the fixed dependency: https://github.com/ferferga/ferferga/actions/runs/3755998187/jobs/6381582666

Thank you very much for all your support throughout this issue! Please, mark my message as answer, GH doesn't allow me to do that.