Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the RandomResize class #74

Open
jluwula opened this issue Sep 25, 2024 · 1 comment
Open

Question about the RandomResize class #74

jluwula opened this issue Sep 25, 2024 · 1 comment

Comments

@jluwula
Copy link

jluwula commented Sep 25, 2024

Hello! @lpiccinelli-eth
Thanks for this outstanding work!
Recently I read your code and I was confused by the class RandomResize in unidepth.utils.transform. The following code is in line 783 and 784.
if intrinsic is not None: intrinsic = [intrinsic[0], intrinsic[1], intrinsic[2]*resize_ratio, intrinsic[3]*resize_ratio]
Why the fx and fy are not changed after resize? Do you use this class during training?

@lpiccinelli-eth
Copy link
Owner

The RandomResize class is outdated, we use the ContextCrop class, you can check PR #76 (branch: training) to see how the data loading is actually carried out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants