Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better matching #3

Open
lubien opened this issue Jan 17, 2017 · 9 comments
Open

Better matching #3

lubien opened this issue Jan 17, 2017 · 9 comments
Assignees

Comments

@lubien
Copy link
Owner

lubien commented Jan 17, 2017

I should improve command matching to accept arguments the more natural way.

@lubien lubien self-assigned this Jan 17, 2017
@v0idpwn
Copy link
Contributor

v0idpwn commented Mar 21, 2019

How does it accept args rn?

@lubien
Copy link
Owner Author

lubien commented Mar 21, 2019

Mostly magic variables from macros.

I'm open to suggestions

@v0idpwn
Copy link
Contributor

v0idpwn commented Mar 21, 2019

# You can create command interfaces for callback querys using this macro.
  callback_query_command "choose" do
    Logger.log :info, "Callback Query Command /choose"

    case update.callback_query.data do
      "/choose joseph" ->
        answer_callback_query text: "Indeed you have good taste."
      "/choose joseph-of-course" ->
        answer_callback_query text: "I can't agree more."
    end
end

How can I use this out of callbacks? I didn't figured out. I could add an example to commands.ex, if I manage to do it.

@lubien
Copy link
Owner Author

lubien commented Mar 21, 2019

I don't understand your question

@v0idpwn
Copy link
Contributor

v0idpwn commented Mar 21, 2019

Just something I didn't found on docs and wasn't obvious for me. I'll PR soon.

@lubien
Copy link
Owner Author

lubien commented Mar 21, 2019

Ok. But I think this case is not what this issue is about. Perhaps you should create another one.

@v0idpwn
Copy link
Contributor

v0idpwn commented Jun 6, 2019

How would it be the most natural way? Something like the POSIX standards? I'm afraid I don't get it, but I'd be happy to help.

@lubien
Copy link
Owner Author

lubien commented Jun 6, 2019

Ever since #17 I've been tinkering around this issue.

I expect making a draft soon so we can perhaps discuss. How about that?

@v0idpwn
Copy link
Contributor

v0idpwn commented Jun 7, 2019

great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants