Improve error messages #639
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
=======================================
Coverage 50.25% 50.25%
=======================================
Files 86 86
Lines 6230 6230
=======================================
Hits 3131 3131
Misses 2887 2887
Partials 212 212 Continue to review full report at Codecov.
|
retpolanne
reviewed
Jul 14, 2020
| @@ -12,8 +12,8 @@ var ( | |||
| ErrInvalidName = status.Errorf(codes.InvalidArgument, "Invalid App Name") | |||
| ErrInvalidLimits = status.Errorf(codes.InvalidArgument, "Invalid Limits") | |||
| ErrInvalidAutoscale = status.Errorf(codes.InvalidArgument, "Invalid Autoscale") | |||
| ErrInvalidEnvVarName = status.Errorf(codes.InvalidArgument, "Invalid Env Var Name") | |||
| ErrInvalidSecretName = status.Errorf(codes.InvalidArgument, "Invalid Secret Name") | |||
| ErrInvalidEnvVarName = status.Errorf(codes.InvalidArgument, "Invalid Env Var Name (Could be a secret already set)") | |||
There was a problem hiding this comment.
Maybe use Invalid Env Var Name, or Env Var already set instead, since it gives the impression that you can use a secret or env var that is already set (that's just 💅 though).
Also, I think you should swap the message here with the message below
Suggested change
| ErrInvalidEnvVarName = status.Errorf(codes.InvalidArgument, "Invalid Env Var Name (Could be a secret already set)") | |
| ErrInvalidEnvVarName = status.Errorf(codes.InvalidArgument, "Invalid Env Var Name (Could be a env var already set)") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some suggestions about the origin of error