Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the visualization function 'cls_padding' in demo.ipynb #19

Open
star-journey opened this issue May 16, 2023 · 0 comments

Comments

@star-journey
Copy link

I appreciate your interesting work.
In the cls_padding function, there are two lines that seem to be a bug:

    mask = mask / max(np.max(mask),cls_weight)
    cls_weight = cls_weight / max(np.max(mask),cls_weight)

In the first line, the variable mask is modified. This means that the value of max(np.max(mask), cls_weight) in the second line will be different. I believe this should be a normalization operation. Can you confirm if this is a bug or a feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant