From e7eec29ac9207f43769d4132ba1d2559e863dfeb Mon Sep 17 00:00:00 2001 From: Brad Chamberlain Date: Thu, 11 Jul 2024 13:58:23 -0700 Subject: [PATCH 1/2] Enable localization-of-domains optimization by default Setting this up to understand performance impacts in playground in hopes of enabling this optimization for 2.2 --- Signed-off-by: Brad Chamberlain --- modules/internal/ChapelArray.chpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/internal/ChapelArray.chpl b/modules/internal/ChapelArray.chpl index 0d586bcb1814..c25c0179c60b 100644 --- a/modules/internal/ChapelArray.chpl +++ b/modules/internal/ChapelArray.chpl @@ -3061,7 +3061,7 @@ module ChapelArray { // default because it was completed close to Chapel 2.1 and we // wanted more time to live with it before having it on by default. // - config param localizeConstDomains = false, + config param localizeConstDomains = true, debugLocalizedConstDomains = false; pragma "init copy fn" From a8b6a1af7712c97501d1a81c45edff1d756f508c Mon Sep 17 00:00:00 2001 From: Brad Chamberlain Date: Wed, 21 Aug 2024 14:52:36 -0700 Subject: [PATCH 2/2] Update comment around optimization and update tests that were enabling manually --- Signed-off-by: Brad Chamberlain --- modules/internal/ChapelArray.chpl | 4 +--- test/arrays/localizeConstDom.compopts | 2 +- test/arrays/sparse/copyRemoteSparse-cs.compopts | 4 ++-- test/arrays/sparse/copyRemoteSparse.compopts | 2 +- test/distributions/block/checkLocalizeConstBlockDom.compopts | 2 +- test/studies/spsMatMatMult/driver.compopts | 2 +- 6 files changed, 7 insertions(+), 9 deletions(-) diff --git a/modules/internal/ChapelArray.chpl b/modules/internal/ChapelArray.chpl index c25c0179c60b..1886285001f2 100644 --- a/modules/internal/ChapelArray.chpl +++ b/modules/internal/ChapelArray.chpl @@ -3057,9 +3057,7 @@ module ChapelArray { // // These control an optimization in which copying an array from one // locale to another will also copy the array's domain if we believe - // it's safe to do so. This optimization is currently off by - // default because it was completed close to Chapel 2.1 and we - // wanted more time to live with it before having it on by default. + // it's safe to do so. The optimization is currently on by default. // config param localizeConstDomains = true, debugLocalizedConstDomains = false; diff --git a/test/arrays/localizeConstDom.compopts b/test/arrays/localizeConstDom.compopts index d542e4374a27..57aa819cca27 100644 --- a/test/arrays/localizeConstDom.compopts +++ b/test/arrays/localizeConstDom.compopts @@ -1 +1 @@ --slocalizeConstDomains=true -sdebugLocalizedConstDomains=true +-sdebugLocalizedConstDomains=true diff --git a/test/arrays/sparse/copyRemoteSparse-cs.compopts b/test/arrays/sparse/copyRemoteSparse-cs.compopts index 7cdf1c6be604..d1f318bccfaa 100644 --- a/test/arrays/sparse/copyRemoteSparse-cs.compopts +++ b/test/arrays/sparse/copyRemoteSparse-cs.compopts @@ -1,2 +1,2 @@ --slocalizeConstDomains=true -sdebugLocalizedConstDomains=true --no-cache-remote -scompressRows=true --slocalizeConstDomains=true -sdebugLocalizedConstDomains=true --no-cache-remote -scompressRows=false +-sdebugLocalizedConstDomains=true --no-cache-remote -scompressRows=true +-sdebugLocalizedConstDomains=true --no-cache-remote -scompressRows=false diff --git a/test/arrays/sparse/copyRemoteSparse.compopts b/test/arrays/sparse/copyRemoteSparse.compopts index 6b1a9f71f542..f98c600db9f3 100644 --- a/test/arrays/sparse/copyRemoteSparse.compopts +++ b/test/arrays/sparse/copyRemoteSparse.compopts @@ -1 +1 @@ --slocalizeConstDomains=true -sdebugLocalizedConstDomains=true --no-cache-remote +-sdebugLocalizedConstDomains=true --no-cache-remote diff --git a/test/distributions/block/checkLocalizeConstBlockDom.compopts b/test/distributions/block/checkLocalizeConstBlockDom.compopts index d542e4374a27..57aa819cca27 100644 --- a/test/distributions/block/checkLocalizeConstBlockDom.compopts +++ b/test/distributions/block/checkLocalizeConstBlockDom.compopts @@ -1 +1 @@ --slocalizeConstDomains=true -sdebugLocalizedConstDomains=true +-sdebugLocalizedConstDomains=true diff --git a/test/studies/spsMatMatMult/driver.compopts b/test/studies/spsMatMatMult/driver.compopts index c483e52c9862..e5496b3fdc56 100644 --- a/test/studies/spsMatMatMult/driver.compopts +++ b/test/studies/spsMatMatMult/driver.compopts @@ -1 +1 @@ ---no-cache-remote -slocalizeConstDomains=true +--no-cache-remote