Skip to content
This repository has been archived by the owner on Nov 14, 2019. It is now read-only.

Make error messages easier to read #23

Open
cyberixae opened this issue Oct 2, 2019 · 0 comments
Open

Make error messages easier to read #23

cyberixae opened this issue Oct 2, 2019 · 0 comments

Comments

@cyberixae
Copy link
Contributor

cyberixae commented Oct 2, 2019

Missing tokenId currently produces the following error.

File _customer-profile.json contains an invalid customerProfile example: Invalid value "TOKEN" supplied to : Default/balances: ((Partial<{ WMP: (Partial<{ currency: "WMP", amount: number }> & { currency: (UnknownRecord | UnknownArray | string | boolean | number | null), amount: (UnknownRecord | UnknownArray | string | boolean | number | null) }) }> & { [K in string]: ((Partial<{ currency: "WMP", amount: number }> & { currency: (UnknownRecord | UnknownArray | string | boolean | number | null), amount: (UnknownRecord | UnknownArray | string | boolean | number | null) }) | (Partial<{ currency: "TOKEN", tokenId: TokenId, amount: (number | null) }> & { currency: (UnknownRecord | UnknownArray | string | boolean | number | null), tokenId: (UnknownRecord | UnknownArray | string | boolean | number | null), amount: (UnknownRecord | UnknownArray | string | boolean | number | null) })) }) & { WMP: (UnknownRecord | UnknownArray | string | boolean | number | null) })/0: (Partial<{ WMP: (Partial<{ currency: "WMP", amount: number }> & { currency: (UnknownRecord | UnknownArray | string | boolean | number | null), amount: (UnknownRecord | UnknownArray | string | boolean | number | null) }) }> & { [K in string]: ((Partial<{ currency: "WMP", amount: number }> & { currency: (UnknownRecord | UnknownArray | string | boolean | number | null), amount: (UnknownRecord | UnknownArray | string | boolean | number | null) }) | (Partial<{ currency: "TOKEN", tokenId: TokenId, amount: (number | null) }> & { currency: (UnknownRecord | UnknownArray | string | boolean | number | null), tokenId: (UnknownRecord | UnknownArray | string | boolean | number | null), amount: (UnknownRecord | UnknownArray | string | boolean | number | null) })) })/1: { [K in string]: ((Partial<{ currency: "WMP", amount: number }> & { currency: (UnknownRecord | UnknownArray | string | boolean | number | null), amount: (UnknownRecord | UnknownArray | string | boolean | number | null) }) | (Partial<{ currency: "TOKEN", tokenId: TokenId, amount: (number | null) }> & { currency: (UnknownRecord | UnknownArray | string | boolean | number | null), tokenId: (UnknownRecord | UnknownArray | string | boolean | number | null), amount: (UnknownRecord | UnknownArray | string | boolean | number | null) })) }/cx-test-token_v2: ((Partial<{ currency: "WMP", amount: number }> & { currency: (UnknownRecord | UnknownArray | string | boolean | number | null), amount: (UnknownRecord | UnknownArray | string | boolean | number | null) }) | (Partial<{ currency: "TOKEN", tokenId: TokenId, amount: (number | null) }> & { currency: (UnknownRecord | UnknownArray | string | boolean | number | null), tokenId: (UnknownRecord | UnknownArray | string | boolean | number | null), amount: (UnknownRecord | UnknownArray | string | boolean | number | null) }))/0: (Partial<{ currency: "WMP", amount: number }> & { currency: (UnknownRecord | UnknownArray | string | boolean | number | null), amount: (UnknownRecord | UnknownArray | string | boolean | number | null) })/0: Partial<{ currency: "WMP", amount: number }>/currency: "WMP"

At least it would be nice if we could translate (UnknownRecord | UnknownArray | string | boolean | number | null) to Defined as that is what it essentially means. In their current form the error messages are too verbose and hide the real error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant