-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for TOML files to the CLI. #277
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #277 +/- ##
==========================================
- Coverage 98.01% 97.96% -0.06%
==========================================
Files 27 27
Lines 4341 4366 +25
Branches 762 765 +3
==========================================
+ Hits 4255 4277 +22
- Misses 56 58 +2
- Partials 30 31 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, wow, this is great! Pretty much perfect, in fact. I've added some Oxford commas and spotted a couple other docs items I'll address post-merge. Thanks so much!
Oh hello there :)
Do you have any interest in TOML support for the CLI? If so, here's a PR -- where I've basically used
tomllib
on 3.11 and tomli before.If you have other preferences on the below obviously feel free to lemme know, or to close if it isn't in scope!