Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support batching multiple Get() requests in a single HTTP request #9

Open
thrawn01 opened this issue Jun 4, 2019 · 3 comments
Open

Support batching multiple Get() requests in a single HTTP request #9

thrawn01 opened this issue Jun 4, 2019 · 3 comments
Labels
todo

Comments

@thrawn01
Copy link
Contributor

thrawn01 commented Jun 4, 2019

This would work just like mailgun/gubernators PeerClient which would wait a few microseconds and batch requests together in a single request. This technique has dramatically improved throughput of gubernator, I imagine groupcache would also benefit. In production we have seen batch sizes of 1k in a single request when queueing for only 500 Microseconds.
@thrawn01 thrawn01 added the todo label Jun 4, 2019
@haifeiWu
Copy link

Is this feature complete?

@thrawn01
Copy link
Contributor Author

thrawn01 commented Mar 2, 2021

No this work was never done.

@haifeiWu
Copy link

haifeiWu commented Mar 3, 2021

If I want to implement this feature, what issues should I pay attention to?

@GiedriusS GiedriusS mentioned this issue Aug 3, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thrawn01 @haifeiWu