Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: wrong mapping which lead to key handle issue #5985

Closed
1 task done
oussamakhadraoui opened this issue Nov 11, 2024 · 2 comments · May be fixed by #5992
Closed
1 task done

[bug]: wrong mapping which lead to key handle issue #5985

oussamakhadraoui opened this issue Nov 11, 2024 · 2 comments · May be fixed by #5992
Assignees
@SatishGandham
Labels
🐛bug Something isn't working

Comments

@oussamakhadraoui
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

Inside the
\web\core\components\ui\loader\projects-loader.tsx
you should change this
{[...Array(3)].map((i) by this {[...Array(3)].map((_,i)

Steps to reproduce

Just make this simple change to prevent the errors

Environment

Production

Browser

Google Chrome

Variant

Self-hosted

Version

last version
@oussamakhadraoui oussamakhadraoui added the 🐛bug Something isn't working label Nov 11, 2024
@pushya22 pushya22 assigned SatishGandham and unassigned vihar and pushya22 Nov 11, 2024
@SatishGandham
Copy link
Collaborator

Thank you, @oussamakhadraoui , for bringing this to our attention. While this issue does not affect the functionality or performance of the application, it’s essential to adhere to best practices and set a strong example, especially for an open-source project of this scale.

We’ve identified several instances of this usage, and we plan to address them all this week.

Again, thank you for taking the time to highlight this issue—we genuinely appreciate your input.

@anmolsinghbhatia anmolsinghbhatia linked a pull request Nov 13, 2024 that will close this issue
[WEB-2762] chore: loader code refactor #5992
Open
@SatishGandham
Copy link
Collaborator

This is fixed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SatishGandham SatishGandham

Labels
🐛bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WEB-2762] chore: loader code refactor makeplane/plane
4 participants
@SatishGandham @vihar @oussamakhadraoui @pushya22